Add test coverage for HtmlBindingSniff #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor-sviziev
changed the title
ihor-sviziev
commented
Aug 10, 2021
| @@ -83,7 +83,7 @@ public function process(File $phpcsFile, $stackPtr) | |||
| . ' - "' . $htmlBinding . '" doesn\'t,' . PHP_EOL | |||
| . 'consider using text binding if the value is supposed to be text', | |||
| null, | |||
| 'UIComponentTemplate.KnockoutBinding.HtmlSuffix' | |||
| 'KnockoutBindingHtmlSuffix' | |||
There was a problem hiding this comment.
Note: in past, the error wasn't added at all.
sivaschenko
approved these changes
Aug 19, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the pull request successfully imported. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
May 8, 2023
ACP2E-1919: Implement sniff that reports usage of dynamic properties as deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is port of the following test:
https://github.com/magento/magento2/blob/7c6b6365a3c099509d6f6e6c306cb1821910aab0/dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Html/HtmlBindingSniffTest.php